Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events should be written to the apps log stream #832

Closed
mwildehahn opened this issue May 12, 2016 · 2 comments
Closed

Events should be written to the apps log stream #832

mwildehahn opened this issue May 12, 2016 · 2 comments

Comments

@mwildehahn
Copy link
Contributor

When events are published, we should write them to the log stream

@mwildehahn
Copy link
Contributor Author

@ejholmes to implement this:

that way when an event is published (ie. create/deploy etc) and a stream doesn't exist, the same code is being called to create and write to the stream.

i was thinking if we pulled the kinesis code out of logspout-kinesis that would help us move away from logspout in the future, but if you switch to logstash, you would be using some ruby kinesis output plugin.

i see two options for tackling this:

  1. use kinesis library to write to the stream with the app id, if the stream doesn't exist, just don't write the event.
  2. refactor the stream creation process out of logspout-kinesis and into the kinesis library that will get called by both logspout-kinesis and empire.

1 is the faster implementation that i think makes the most sense. i don't think it matters if you drop some events from the stream, there is no guarantee that the DropWriter isn't going to do that either and the window of the stream not existing is small.

thoughts?

@phobologic
Copy link
Contributor

I'm honestly open to either of them - the fact that logstash seems likely in our future now makes me wonder if this shouldn't just wait for that implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants