Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.4 #1

Merged
merged 7 commits into from
Apr 7, 2015
Merged

Add support for Python 3.4 #1

merged 7 commits into from
Apr 7, 2015

Conversation

yasserglez
Copy link
Contributor

I made some changes to support using the package under Python 3.4. The changes rely on the compatibility layer provided by the six package (it was added as a dependency). The examples still use Python 2 syntax, I've only changed pyeasyga/pyeasyga.py and tests/test_pyeasyga.py in order to make the tests pass.

All tests run fine locally under Python 2.7 and 3.4 using tox. It might incidentally support earlier Python 3 versions, but I haven't checked.

I hope it's useful.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 471970f on yasserglez:py34-support into e155a1f on remiomosowon:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 471970f on yasserglez:py34-support into e155a1f on remiomosowon:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 471970f on yasserglez:py34-support into e155a1f on remiomosowon:develop.

@remiomosowon remiomosowon merged commit 471970f into remiomosowon:develop Apr 7, 2015
@remiomosowon
Copy link
Owner

Thanks! I have merged your pull request, made some minor updates, and added you to the contributors list. When I have the time, I will test support for the other Python 3 versions and update the repo accordingly. Cheers.

@yasserglez
Copy link
Contributor Author

Thank you!

@yasserglez yasserglez deleted the py34-support branch April 7, 2015 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants