Speed up init with a refactor

[thomsbg]

Hopefully this makes for some clearer code inside the initialize method in Her::Model::ORM.

Instead of using writer_method_defined? inside the loop, make use of a use_setter_methods helper function which both calls setter methods and returns a hash of the remaining key / values.

I did this after noticing in profiling output that significant time was being spent in Class#instance_methods (which writer_method_defined? was using inside a loop).

[travisbot]

This pull request passes (merged f807c64 into e33489b).

[travisbot]

This pull request passes (merged e1f5782 into e33489b).

[wingrunr21]

I'd like to see this merged. We have some large objects being pulled in via JSON and it is proving to be expensive to build all of them. Profiling reveals writer_method_defined? is responsible for a good chunk of it.

[remi]

I merged the branch into master. Tests pass, but could you guys check if everything is still working in your applications? Thanks!

[thomsbg]

fwiw, I've been running this code in production for a month or so, no problems.

[wingrunr21]

My app is also looking solid

[remi]

fwiw, I've been running this code in production for a month or so, no problems.

Sweet. Just curious, can you tell me on what app/project you’re using Her? 😄

[thomsbg]

I work for Vox Media, where we're using Her to consume an internal API that powers the games data on Polygon, and the Products data on The Verge

[wingrunr21]

I work for CustomInk. We are moving off of ActiveResource for consuming data from our catalog management system.

[remi]

Wow, this is awesome. So glad to hear other people are using it for real 😀