fix(react-ui): language selector should be a component, not an extension

remirror · Nov 9, 2023 · 5fd894e · 5fd894e
1 parent b3b7947
commit 5fd894e
Show file tree

Hide file tree

Showing 25 changed files with 508 additions and 1,176 deletions.
diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml
@@ -7,7 +7,7 @@ on:
   pull_request:
     types: [opened, synchronize]
     branches:
-      - v1
+      - v3
       - main
 
 env:

diff --git a/.size-limit.json b/.size-limit.json
@@ -530,25 +530,6 @@
     "running": false,
     "gzip": true
   },
-  {
-    "name": "@remirror/extension-react-language-select",
-    "limit": "10 KB",
-    "path": "packages/remirror__extension-react-language-select/dist/remirror-extension-react-language-select.js",
-    "ignore": [
-      "@remirror/pm",
-      "react",
-      "react-dom",
-      "@remirror/core",
-      "@remirror/core-utils",
-      "@remirror/extension-code-block",
-      "@remirror/extension-positioner",
-      "@remirror/react-components",
-      "@remirror/react-core",
-      "@remirror/react-hooks"
-    ],
-    "running": false,
-    "gzip": true
-  },
   {
     "name": "@remirror/extension-react-ssr",
     "limit": "10 KB",

diff --git a/packages/remirror__extension-positioner/src/positioner-extension.ts b/packages/remirror__extension-positioner/src/positioner-extension.ts
@@ -176,6 +176,7 @@ export class PositionerExtension extends PlainExtension<PositionerOptions> {
   private createElement() {
     const element = document.createElement('span');
     element.dataset.id = POSITIONER_WIDGET_KEY;
+    element.classList.add(POSITIONER_WIDGET_KEY);
     element.setAttribute('role', 'presentation');
 
     return element;

diff --git a/packages/remirror__extension-react-language-select/CHANGELOG.md b/packages/remirror__extension-react-language-select/CHANGELOG.md
diff --git a/packages/remirror__extension-react-language-select/package.json b/packages/remirror__extension-react-language-select/package.json
diff --git a/packages/remirror__extension-react-language-select/readme.md b/packages/remirror__extension-react-language-select/readme.md
diff --git a/packages/remirror__extension-react-language-select/src/index.ts b/packages/remirror__extension-react-language-select/src/index.ts