chore: remirror-cli watch shouldn't override package.json files (#1841)

remirror · Sep 9, 2022 · cf39718 · cf39718 · github-actions · Sep 9, 2022
1 parent 2810643
commit cf39718
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/remirror__cli/src/commands/watch.ts b/packages/remirror__cli/src/commands/watch.ts
@@ -46,7 +46,7 @@ export async function watch(options: { skipBuild?: boolean }) {
     ignorePermissionErrors: true,
   });
   const executor = new DebounceExecutor(async (dir: string) => {
-    await buildPackage(packageDirMap[dir]);
+    await buildPackage(packageDirMap[dir], false);
     await runTsc();
   });
 

diff --git a/packages/remirror__cli/src/utils/build-package.ts b/packages/remirror__cli/src/utils/build-package.ts
@@ -18,12 +18,14 @@ import { writePackageJson } from './write-package-json';
 /**
  * Bundle a package using esbuild and update `package.json` if necessary.
  */
-export async function buildPackage(pkg: Package) {
+export async function buildPackage(pkg: Package, writePackageJson = true) {
   logger.info(`${colors.blue(pkg.packageJson.name)} building...`);
 
   const entryPoints = await parseEntryPoints(pkg);
 
-  await writeMainPackageJson(pkg, entryPoints);
+  if (writePackageJson) {
+    await writeMainPackageJson(pkg, entryPoints);
+  }
 
   const promises: Array<Promise<unknown>> = [];
 
@@ -46,8 +48,10 @@ export async function buildPackage(pkg: Package) {
     }
   }
 
-  for (const entryPoint of entryPoints.filter((entryPoint) => !entryPoint.isMain)) {
-    promises.push(writeSubpathPackageJson(pkg, entryPoint));
+  if (writePackageJson) {
+    for (const entryPoint of entryPoints.filter((entryPoint) => !entryPoint.isMain)) {
+      promises.push(writeSubpathPackageJson(pkg, entryPoint));
+    }
   }
 
   await Promise.all(promises);