fix(core-helpers): remove type guard from isEmpty* predicates

remirror · Jul 27, 2020 · d8aa243 · d8aa243
1 parent 1fcdcff
commit d8aa243
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/tiny-bees-listen.md b/.changeset/tiny-bees-listen.md
@@ -0,0 +1,5 @@
+---
+'@remirror/core-helpers': minor
+---
+
+Remove type guard from `isEmptyArray` and `isEmptyObject` as they were incorrect.
diff --git a/packages/@remirror/core-helpers/src/core-helpers.ts b/packages/@remirror/core-helpers/src/core-helpers.ts
@@ -8,7 +8,6 @@ import { __INTERNAL_REMIRROR_IDENTIFIER_KEY__, RemirrorIdentifier } from '@remir
 import {
   AnyConstructor,
   AnyFunction,
-  EmptyShape,
   Nullable,
   Predicate,
   RemirrorIdentifierShape,
@@ -439,7 +438,7 @@ export function isSet(value: unknown): value is Set<unknown> {
  *
  * @public
  */
-export function isEmptyObject(value: unknown): value is EmptyShape {
+export function isEmptyObject(value: unknown) {
   return isObject(value) && !isMap(value) && !isSet(value) && Object.keys(value).length === 0;
 }
 
@@ -455,7 +454,7 @@ export const isArray = Array.isArray;
  *
  * @public
  */
-export function isEmptyArray(value: unknown): value is never[] {
+export function isEmptyArray(value: unknown) {
   return isArray(value) && value.length === 0;
 }