Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold italic via markdown does not terminate bold as expected #505

Closed
benjie opened this issue Aug 13, 2020 · 1 comment · Fixed by #495
Closed

Bold italic via markdown does not terminate bold as expected #505

benjie opened this issue Aug 13, 2020 · 1 comment · Fixed by #495
Assignees
Labels
status: confirmed 🟢 The bug has been tested and confirmed. type: bug 🪲 Something isn't working
Milestone

Comments

@benjie
Copy link
Member

benjie commented Aug 13, 2020

Summary

After entering _**Bold italic**_ into editor, when you continue typing text is still bold.

Steps to reproduce

  1. Enter the below into remirror playground
  2. Type the following characters at the end of the editor: **_ more words
{
  "doc": {
    "type": "doc",
    "content": [
      {
        "type": "paragraph",
        "content": [
          {
            "type": "text",
            "text": "Here's _**bold italic"
          }
        ]
      }
    ]
  },
  "playground": {
    "m": 0,
    "a": [],
    "e": [
      {
        "module": "remirror/extension/bold",
        "export": "BoldExtension"
      },
      {
        "module": "remirror/extension/italic",
        "export": "ItalicExtension"
      }
    ],
    "p": []
  }
}

Expected results

Bold italic more words

Actual results

Bold italic more words

@benjie benjie added the type: bug 🪲 Something isn't working label Aug 13, 2020
@ifiokjr ifiokjr added the status: confirmed 🟢 The bug has been tested and confirmed. label Aug 13, 2020
@ifiokjr ifiokjr added this to Future in Internal Roadmap via automation Aug 13, 2020
@ifiokjr ifiokjr added this to Needs triage in Bugs via automation Aug 13, 2020
@ifiokjr ifiokjr self-assigned this Aug 13, 2020
@ifiokjr ifiokjr moved this from Needs triage to Low priority in Bugs Aug 13, 2020
@ifiokjr ifiokjr moved this from Future to August: 2020-08-09 (Week) in Internal Roadmap Aug 13, 2020
ifiokjr added a commit that referenced this issue Aug 13, 2020
ifiokjr added a commit that referenced this issue Aug 13, 2020
ifiokjr added a commit that referenced this issue Aug 14, 2020
@ifiokjr
Copy link
Member

ifiokjr commented Aug 14, 2020

What a great format for this issue. It took me less than 2 minutes to verify the bug and once a fix is available it'll also be verifiable via the playground. Love it 😊

ifiokjr added a commit that referenced this issue Aug 14, 2020
@ifiokjr ifiokjr added this to Ready in remirror@1.0.0 Aug 14, 2020
remirror@1.0.0 automation moved this from Ready to Done Aug 14, 2020
Internal Roadmap automation moved this from August: 2020-08-09 (Week) to Published Aug 14, 2020
Bugs automation moved this from Low priority to Closed Aug 14, 2020
@ifiokjr ifiokjr added this to the fix outstanding bugs milestone Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed 🟢 The bug has been tested and confirmed. type: bug 🪲 Something isn't working
Projects
Bugs
  
Closed
Internal Roadmap
  
Released
Development

Successfully merging a pull request may close this issue.

2 participants