Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to exit inline marks when at the end of the document #636

Closed
ifiokjr opened this issue Sep 4, 2020 · 0 comments · Fixed by #668
Closed

No way to exit inline marks when at the end of the document #636

ifiokjr opened this issue Sep 4, 2020 · 0 comments · Fixed by #668
Assignees
Labels
package: remirror 🟣 Label for the remirror package and all relevant scoped `@remirror/*` packages. status: confirmed 🟢 The bug has been tested and confirmed. status: sponsored 💖 All issues and pull requests which have been requested from or created by sponsors. type: bug 🪲 Something isn't working type: feature ✨ A new feature is being added to the public API

Comments

@ifiokjr
Copy link
Member

ifiokjr commented Sep 4, 2020

Summary

Playground Link

When within a bold code or italic mark, there is no easy way to exit the mark if the cursor is at the end of the document.

Steps to reproduce

  • Navigate to the playground
  • Type **Bold**
  • Press LeftArrowKey and then RightArrowKey
  • Start typing and try to escape the bold without shortcuts.

Expected results

You should be able to escape the current mark when at the end of the document by pressing the left / right (Left/Right)ArrowKey.

Actual results

There is no escape without using Ctrl/Cmd-b 😰

Possible Solution

Add a configurable property for all mark extensions which allows them to be escaped when certain criteria are met.

If at the end of the document and the right arrow is pressed within an LTR document or the left arrow is pressed within an RTL document then remove the mark from being active.

Perhaps it should be made the default.

Screenshot

2020-09-04 08 38 48

@ifiokjr ifiokjr added type: bug 🪲 Something isn't working type: feature ✨ A new feature is being added to the public API package: remirror 🟣 Label for the remirror package and all relevant scoped `@remirror/*` packages. status: confirmed 🟢 The bug has been tested and confirmed. status: sponsored 💖 All issues and pull requests which have been requested from or created by sponsors. labels Sep 4, 2020
@ifiokjr ifiokjr added this to the Core Improvements milestone Sep 4, 2020
@ifiokjr ifiokjr added this to Future in Internal Roadmap via automation Sep 4, 2020
@ifiokjr ifiokjr added this to Needs triage in Bugs via automation Sep 4, 2020
@ifiokjr ifiokjr added this to To do in remirror@1.0.0 via automation Sep 4, 2020
@ifiokjr ifiokjr moved this from Needs triage to Default Priority in Bugs Sep 4, 2020
@ifiokjr ifiokjr moved this from Future to September: 2020-09-06 (Week) in Internal Roadmap Sep 4, 2020
@ifiokjr ifiokjr moved this from September: 2020-09-06 (Week) to September: 2020-09-13 (Week) in Internal Roadmap Sep 6, 2020
@ifiokjr ifiokjr self-assigned this Sep 8, 2020
ifiokjr added a commit that referenced this issue Sep 9, 2020
ifiokjr added a commit that referenced this issue Sep 9, 2020
ifiokjr added a commit that referenced this issue Sep 9, 2020
remirror@1.0.0 automation moved this from To do to Done Sep 9, 2020
Bugs automation moved this from Default Priority to Closed Sep 9, 2020
Internal Roadmap automation moved this from September: 2020-09-20 (Week) to Released Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: remirror 🟣 Label for the remirror package and all relevant scoped `@remirror/*` packages. status: confirmed 🟢 The bug has been tested and confirmed. status: sponsored 💖 All issues and pull requests which have been requested from or created by sponsors. type: bug 🪲 Something isn't working type: feature ✨ A new feature is being added to the public API
Projects
Bugs
  
Closed
Internal Roadmap
  
Released
Development

Successfully merging a pull request may close this issue.

1 participant