Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing typescript definitions #77

Closed
eric-edouard opened this issue Apr 9, 2019 · 3 comments · Fixed by #84
Closed

Missing typescript definitions #77

eric-edouard opened this issue Apr 9, 2019 · 3 comments · Fixed by #84
Labels
type: bug 🪲 Something isn't working

Comments

@eric-edouard
Copy link

Description

Hi, thanks for this great project. I'm having an issue while trying to run the basic example:

Screenshot 2019-04-09 at 09 23 44

It seems the packages makes reference to files located in "support", which are not exported.

Thanks

@ifiokjr ifiokjr added the type: bug 🪲 Something isn't working label Apr 9, 2019
@ifiokjr
Copy link
Member

ifiokjr commented Apr 9, 2019

Thanks for raising this @ericedouard. I can fix it by moving all type patches into the packages that consume them. I'll have to look into hoistNonReactStatics though.

@ifiokjr
Copy link
Member

ifiokjr commented Apr 9, 2019

@ericedouard as a short-term fix have you tried adding "skipLibCheck": true, to your tsconfig.json compilerOptions.

@eric-edouard
Copy link
Author

eric-edouard commented Apr 9, 2019

@ifiokjr That did the trick, thanks !
Congrats on this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants