Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize embeds from remirror-iframe #840

Closed
ronnyroeller opened this issue Jan 19, 2021 · 2 comments
Closed

Resize embeds from remirror-iframe #840

ronnyroeller opened this issue Jan 19, 2021 · 2 comments
Labels
status: sponsored 💖 All issues and pull requests which have been requested from or created by sponsors.

Comments

@ronnyroeller
Copy link
Collaborator

Description

The iframe-extension renders an iframe to embed external content like YouTube videos.

The extension should allow users to resize the iframe. Depending on the embed, this could be with fixed aspect ratio (e.g. for YouTube videos) or with flexible aspect ratio (e.g. for Miro boards).

Inspiration from other systems

Fixed aspect ratio

Notion example for horizontal only resizing (see handlebars on left/right):
image

Flexible aspect ratio

Notion example for horizontal and vertical resizing (see handlebars on left/right/bottom and in corners):
image

@github-actions github-actions bot added the status: sponsored 💖 All issues and pull requests which have been requested from or created by sponsors. label Jan 19, 2021
@Gaaaga
Copy link
Collaborator

Gaaaga commented Jul 11, 2021

Currently working on this :)

@ronnyroeller
Copy link
Collaborator Author

Fixed by @Gaaaga via #999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: sponsored 💖 All issues and pull requests which have been requested from or created by sponsors.
Projects
None yet
Development

No branches or pull requests

2 participants