New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commands.insertHorizontalRule
positioning
#641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the main package.json name to `remirror-monorepo`.
ifiokjr
added
type: fix 🔧
A pull request that fixes a known bug.
status: sponsored 💖
All issues and pull requests which have been requested from or created by sponsors.
labels
Sep 4, 2020
🦋 Changeset is good to goLatest commit: e97a717 We got this. This PR includes changesets to release 63 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
package: remirror 🟣
Label for the remirror package and all relevant scoped `@remirror/*` packages.
test: unit ✅
A label for updating tests and test configuration.
type: changeset 🦋
A change has been made to the changesets folder.
labels
Sep 4, 2020
This was referenced Sep 4, 2020
Closed
🚀 Deployed on https://5f527bbe1e08f308bd368cd8--remirror.netlify.app |
ifiokjr
changed the title
Fix
Fix Sep 4, 2020
commands.insertHorizontalRule
wrong positioncommands.insertHorizontalRule
positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: remirror 🟣
Label for the remirror package and all relevant scoped `@remirror/*` packages.
status: sponsored 💖
All issues and pull requests which have been requested from or created by sponsors.
test: unit ✅
A label for updating tests and test configuration.
type: changeset 🦋
A change has been made to the changesets folder.
type: fix 🔧
A pull request that fixes a known bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isEmptyBlockNode
function from@remirror/extension-positioner
to@remirror/core-utils
. Re-export to prevent breaking change.commands.insertHorizontalRule
inserting the line in the wrong position.Fixes #620
Checklist
pnpm fix
completed successfully.pnpm test
.Screenshots