Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands.insertHorizontalRule positioning #641

Merged
merged 2 commits into from Sep 4, 2020
Merged

Fix commands.insertHorizontalRule positioning #641

merged 2 commits into from Sep 4, 2020

Conversation

ifiokjr
Copy link
Member

@ifiokjr ifiokjr commented Sep 4, 2020

Description

  • Move isEmptyBlockNode function from @remirror/extension-positioner to @remirror/core-utils. Re-export to prevent breaking change.
  • Fix commands.insertHorizontalRule inserting the line in the wrong position.

Fixes #620

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

Screenshots

2020-09-04 18 30 47

@ifiokjr ifiokjr added type: fix 🔧 A pull request that fixes a known bug. status: sponsored 💖 All issues and pull requests which have been requested from or created by sponsors. labels Sep 4, 2020
@ifiokjr ifiokjr added this to the Sponsorship Tasks milestone Sep 4, 2020
@ifiokjr ifiokjr self-assigned this Sep 4, 2020
@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2020

🦋 Changeset is good to go

Latest commit: e97a717

We got this.

This PR includes changesets to release 63 packages
Name Type
@remirror/core-utils Major
@remirror/extension-positioner Major
@remirror/extension-horizontal-rule Major
@remirror/core Major
jest-prosemirror Major
remirror Major
@remirror/extension-annotation Major
@remirror/preset-core Major
@remirror/react-hooks Major
@remirror/react Major
@remirror/preset-wysiwyg Major
@remirror/dom Major
@remirror/extension-auto-link Major
@remirror/extension-bidi Major
@remirror/extension-blockquote Major
@remirror/extension-bold Major
@remirror/extension-code-block Major
@remirror/extension-code Major
@remirror/extension-collaboration Major
@remirror/extension-diff Major
@remirror/extension-doc Major
@remirror/extension-drop-cursor Major
@remirror/extension-emoji Major
@remirror/extension-epic-mode Major
@remirror/extension-events Major
@remirror/extension-gap-cursor Major
@remirror/extension-hard-break Major
@remirror/extension-heading Major
@remirror/extension-history Major
@remirror/extension-image Major
@remirror/extension-italic Major
@remirror/extension-link Major
@remirror/extension-mention-atom Major
@remirror/extension-mention Major
@remirror/extension-paragraph Major
@remirror/extension-placeholder Major
@remirror/extension-position-tracker Major
@remirror/extension-react-component Major
@remirror/extension-react-ssr Major
@remirror/extension-search Major
@remirror/extension-strike Major
@remirror/extension-text Major
@remirror/extension-trailing-node Major
@remirror/extension-underline Major
@remirror/extension-yjs Major
@remirror/playground Major
@remirror/preset-embed Major
@remirror/preset-list Major
@remirror/preset-react-checkbox Major
@remirror/preset-react Major
@remirror/preset-social Major
@remirror/preset-table Major
@remirror/react-components Major
@remirror/react-social Major
@remirror/react-wysiwyg Major
@remirror/showcase Major
@remirror/testing Patch
jest-remirror Major
@remirror/e2e Patch
@remirror/storybook Patch
@remirror/website Patch
with-next Patch
@remirror/dev Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added package: remirror 🟣 Label for the remirror package and all relevant scoped `@remirror/*` packages. test: unit ✅ A label for updating tests and test configuration. type: changeset 🦋 A change has been made to the changesets folder. labels Sep 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

@ifiokjr ifiokjr changed the title Fix commands.insertHorizontalRule wrong position Fix commands.insertHorizontalRule positioning Sep 4, 2020
@ifiokjr ifiokjr added this to Ready in Bugs Sep 4, 2020
@ifiokjr ifiokjr merged commit e7b0bb0 into next Sep 4, 2020
Bugs automation moved this from Ready to Closed Sep 4, 2020
@ifiokjr ifiokjr deleted the issue/620 branch September 4, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: remirror 🟣 Label for the remirror package and all relevant scoped `@remirror/*` packages. status: sponsored 💖 All issues and pull requests which have been requested from or created by sponsors. test: unit ✅ A label for updating tests and test configuration. type: changeset 🦋 A change has been made to the changesets folder. type: fix 🔧 A pull request that fixes a known bug.
Projects
Bugs
  
Closed
Development

Successfully merging this pull request may close these issues.

insertHorizontalRule command inserts in the wrong position
1 participant