Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

fix: useSWEffect's isPromise checks for null #10

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: useSWEffect's isPromise checks for null #10

merged 1 commit into from
May 30, 2023

Conversation

rphlmr
Copy link
Contributor

@rphlmr rphlmr commented May 30, 2023

@rphlmr
Copy link
Contributor Author

rphlmr commented May 30, 2023

@ShafSpecs Tell me if it's good for you ;)

ShafSpecs
ShafSpecs approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@ShafSpecs ShafSpecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShafSpecs ShafSpecs merged commit a6e7bc8 into remix-pwa:main May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ShafSpecs ShafSpecs ShafSpecs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useSWEffect breaks an app that requires authentication
2 participants
@rphlmr @ShafSpecs