Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(_official-realtime-app): fix dev script #132

Merged
merged 1 commit into from Feb 1, 2023

Conversation

MichaelDeBoey
Copy link
Member

Closes #106

@machour
Copy link
Collaborator

machour commented Jan 18, 2023

Doesn't seem to work at all for me on v16, v18 or even v19.
Any action seems to instantly revert, and the event is never broadcasted to the other window.

Here's what I'm seeing:

Screen.Recording.2023-01-18.at.3.22.35.PM.mov

If I get back to the main, it works again for me on v19

@MichaelDeBoey
Copy link
Member Author

@machour It was also working before locally, so probably the build cache or so that was out of date when I checked 🤔

Strange that it doesn't work as server.js was the default one without extras, so removing it (and the express adapter) and using just remix dev should work normally 🤔

@sergiodxa Could this be because we're not using the express adapter anymore & remix-utils need it when using useEventSource?

@mcansh
Copy link
Contributor

mcansh commented Feb 1, 2023

this PR appears to work again (with Remix 1.12.0)

@mcansh mcansh merged commit 1ed73b7 into remix-run:main Feb 1, 2023
@MichaelDeBoey MichaelDeBoey deleted the fix-realtime-example branch February 1, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_official-realtime-app can't be run
3 participants