Handle location descriptors in createLocation #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(location.search).toEqual('?the=query') | ||
| }) | ||
|
|
||
| it('works with object with query', function () { |
There was a problem hiding this comment.
This case will not work without this patch.
|
@mjackson Can you look at this when you get a chance, and maybe cut 2.0.0-rc2 off this? It's blocking a few more API cleanups we need for the router. |
taion
force-pushed
the
fix-createLocation
branch
3 times, most recently
from
f6d0de1
to
d80919d
Compare
|
On second thought, this might be the wrong implementation; instead, we're probably better off just passing fields through |
|
Nope, never mind, that doesn't work. |
|
Updated for better forward-compat with remix-run/react-router#2859. |
taion
force-pushed
the
fix-createLocation
branch
from
2a2a98a
to
aabd91b
Compare
|
Looks like the changes merge conflict. That's why I tend to leave docs out of PRs. For now, just rebase and get it green 😄 |
This allows preserving the behavior in React Router of using explicit undefined query values to require query values to be missing for isActive, and prevents unnecessary query string parsing.
taion
force-pushed
the
fix-createLocation
branch
from
aabd91b
to
fd4f28a
Compare
|
Eh, just rebased for now. |
ryanflorence
added a commit
that referenced
this pull request
Jan 17, 2016
Handle location descriptors in createLocation
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.