Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCRIPT16389: Unspecified error. IE11 on page refresh #230

Closed
wants to merge 2 commits into from

Conversation

glynjonesatwork
Copy link

If there is no browser history in the window in IE11 the window.history.state throws an unspecified error. Wrap in try catch.
Similar issue found in Angular angular/angular.js#10367

If there is no browser history in the window in IE11 the window.history.state throws an unspecified error. Wrap in try catch.
@ericingram
Copy link

We also have this issue. Any chance it will be fixed/merged into master?

@taion
Copy link
Contributor

taion commented Mar 7, 2016

There's a merge conflict as-is.

Can you elaborate on how to reproduce the initial issue? We do run tests against IE10 and IE11, and we're not seeing them fail.

@ericingram
Copy link

The problem we're seeing is inside an iframe on IE 11+ (same domain). Adding a try catch around window.history.state solves the problem for us.

@glynjonesatwork
Copy link
Author

We found the issue when you try and refresh a page that has just been initally loaded. If the IE11 window has not navigated to any other page and has no history, this causes the problem. A particular issue for us with a single-page app.

@kirylkastko
Copy link

@glynjonesatwork Could you please fix a conflict on your pull request? Thank you in advance!

@taion
Copy link
Contributor

taion commented May 5, 2016

BTW, note that 2.x is on the v2.x branch, not master.

@taion
Copy link
Contributor

taion commented May 5, 2016

Replaced by #289.

@taion taion closed this May 5, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants