Update query-string major version #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,7 +67,12 @@ | |||
| "location" | |||
| ], | |||
| "babel": { | |||
| "presets": [ "es2015", "stage-1" ], | |||
| "plugins": [ "dev-expression" ] | |||
| "presets": [ | |||
|
I'm gonna fix the failing tests and get this into the v3 release. Thanks for bringing it to my attention, @taion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives better deduping if users (like me!) are manually installing query-string.
I'm not adding this to the v2 branch (even though I want to have this change), because this brings back the (IMO correct)
Object.create(null)behavior, and that's technically breaking, as we surface these objects back to the user.