Remove redundant '?' from search in createLocation

[vimkin]

Here is a fix for an issue that is marked for 4.11 release in a following roadmap #689 and reported in the #701. It appears this issue is caused because of createLocation and not createHref as it is stated in the roadmap. The former was just copying it without modifying to the output.

More in depth:

1. Link from react-router-dom calls navigate on click

navigate() {
  // e.g. 'to' equals to { pathname: "/the/path", search: `?` }
  const location = resolveToLocation(to, context.location);
  const method = replace ? history.replace : history.push;

  // location descriptor is passed unchanged to corresponding history method
  // { pathname: "/the/path", search: `?` }
  method(location);
}

2. history.push or history.replace are called and here is some common code from theirs body

// creates location from location descriptor passed from Link component
// path equals to { pathname: "/the/path", search: `?` }
const location = createLocation(path, state, createKey(), history.location);

// ... afterwards it sets location to the history state
setState({ action, location });

3. Since '?' wasn't cleaned anywhere it ended up in the next state and caused redundant refetches, rerenders etc.

[vimkin]

Super strange fail of the job with TEST_ENV=source: Edge 17.17134.0 (Windows 10.0.0) a browser history push state calls change listeners with the new location FAILED. May it be flaky CI bug because everything else is perfectly running without errors?

[trymbill]

So ... this being merged anytime soon?

[chaance]

This was unintentionally closed because I deleted the master branch after renaming to main, very sorry about that! Feel free to open a new PR, but know I've bookmarked this for review either way.