New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove all TypeScript references when isTypeScript
is passed as false
to remix.init
#63
Conversation
Not sure but for me to get this to work I have to:
|
7ee468b
to
92230b3
Compare
027fef5
to
e68c044
Compare
0b5cb3d
to
d5676a6
Compare
4f2c8d7
to
63af32a
Compare
63af32a
to
ae08e5f
Compare
b73f09b
to
fd81113
Compare
fd81113
to
7c2506f
Compare
7c2506f
to
5fab3b9
Compare
5fab3b9
to
49c4135
Compare
I handled this. We can probably make improvements when that PR is merged though. Let's close this one for now though |
@kentcdodds I rebased my changes onto latest Re-opening this as this can now be reviewed again. |
49c4135
to
159e906
Compare
159e906
to
04244e1
Compare
…as `false` to `remix.init`
04244e1
to
3b432bc
Compare
@kentcdodds Do you know a possible cause of why Cypress is failing again? |
I think it's possible that Cypress is being a bit flakey 😩 |
Yeah, just tried this locally and couldn't figure out what was up 🤷♂️ |
@kentcdodds Seems like Cypress is passing now 🤔 |
Yep. That's what I call flake. We're probably doing something wrong/suboptimal, but I don't have time right now to dig into what it is... |
Do we first want to fix the flackyness or do we merge this already? |
Oh dang! I didn't realize that the other PR had been merged. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for working so hard on this!
I'll update the PRs of the other stacks asap 👍 |
My installation failed for the Indie stack with the latest remix version and the above (changing seed.js to seed.mjs) fixed it. Here was the error:
|
prisma seed
script to use JSinclude
fromjsconfig
vitest
config with JS versionvitest-tsconfig-paths
with js equivalentcypress
'cy.exec
calls to use JSindex
with JS versionremix-run/remix#3150 needs to be merged first
Closes #61