Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NavLink isPending state does not work when BrowserRouter option 'basename' is set #11194

Closed
alexanderhorner opened this issue Jan 16, 2024 · 4 comments · Fixed by #11195
Labels

Comments

@alexanderhorner
Copy link

What version of React Router are you using?

6.15.0

Steps to Reproduce

Reproduction on Stackblitz

Using the Reproduction:

  1. Click the Link "Link to slow Route"

Steps to reproduce from scratch:

  1. Add a route with a slow loader.
  2. Add basename option
  3. Use NavLink to link to it, and use the isPending render prop somehow

Expected Behavior

When clicking the NavLink, isPending should be true while the loader executes.

Actual Behavior

When clicking the NavLink, isPending is false while the loader executes.

@brophdawg11 brophdawg11 linked a pull request Jan 16, 2024 that will close this issue
@brophdawg11 brophdawg11 added the awaiting release This issue have been fixed and will be released soon label Jan 16, 2024
@brophdawg11
Copy link
Contributor

Fixed by #11195 and will be available in the next release 👍

@alexanderhorner
Copy link
Author

Thank you!

Copy link
Contributor

🤖 Hello there,

We just published version 6.21.3-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.21.3 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11 brophdawg11 removed the awaiting release This issue have been fixed and will be released soon label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants