Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib inclusion in .npmignore #13

Closed
jmreidy opened this issue May 28, 2014 · 1 comment
Closed

lib inclusion in .npmignore #13

jmreidy opened this issue May 28, 2014 · 1 comment

Comments

@jmreidy
Copy link
Contributor

jmreidy commented May 28, 2014

Is there a reason that lib is included in .npmignore? Its inclusion means that react-router doesn't work properly when installed via NPM and required by a tool like browserify (since the main file specified in package.json is within the lib directory).

Removing the lib path from .npmignore fixes the issue - but I didn't know if there were a specific reason for its inclusion in the first place...

@mjackson
Copy link
Member

AFAICT the reason @rpflorence included lib in .npmignore is because we originally had a dist process that compiled our ES6 modules down to AMD, CJS, or globals, so you didn't need to include lib in the npm package. However, we have made the switch to using CJS modules in the source, so it may be appropriate to include lib now. I'm not 100% sure tho, so I'll let @rpflorence comment further.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants