You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a reason that lib is included in .npmignore? Its inclusion means that react-router doesn't work properly when installed via NPM and required by a tool like browserify (since the main file specified in package.json is within the lib directory).
Removing the lib path from .npmignore fixes the issue - but I didn't know if there were a specific reason for its inclusion in the first place...
The text was updated successfully, but these errors were encountered:
AFAICT the reason @rpflorence included lib in .npmignore is because we originally had a dist process that compiled our ES6 modules down to AMD, CJS, or globals, so you didn't need to include lib in the npm package. However, we have made the switch to using CJS modules in the source, so it may be appropriate to include lib now. I'm not 100% sure tho, so I'll let @rpflorence comment further.
Is there a reason that lib is included in .npmignore? Its inclusion means that react-router doesn't work properly when installed via NPM and required by a tool like browserify (since the
main
file specified inpackage.json
is within the lib directory).Removing the lib path from .npmignore fixes the issue - but I didn't know if there were a specific reason for its inclusion in the first place...
The text was updated successfully, but these errors were encountered: