Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link active class not added for routes w/o params on initial load #24

Closed
ryanflorence opened this issue Jun 11, 2014 · 1 comment
Closed

Comments

@ryanflorence
Copy link
Member

These don't work on initial load

http://rpflorence.github.io/react-router/examples/master-detail/#/contact/new
http://rpflorence.github.io/react-router/examples/transitions/#/form

But this does:

http://rpflorence.github.io/react-router/examples/master-detail/#/contact/ryan

My guess is because it has params?

If you click around the classes get added, just not when you land at the route.

@mjackson
Copy link
Member

The URL store wasn't notifying listeners of the change when it was setup.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants