Travis build failing

[des-des]

I have been having trouble today, react-router seems to be crashing our travis build. Here is the error as travis gives it. This problem persists even if I change our history dependency in the package to 1.13.0.. Any advice on solving this would be appreciated.

[SeeThruHead]

In npm 2 peerdeps get installed with ^ which means that npm will update the minor version. Since react relies on history 1.13.x and not 1.x.x this installation pattern will fail. You will need to change history to
~1.13.0

I also ran into this issue today and I'm wondering why react-router relies on 1.13.x specifically. Does history not follow semver?

[des-des]

Thank you! That solved it. Not sure about whether history follows semver.

[timdorr]

@SeeThruHead We do. We have added deprecation warnings for 1.14.0 and 1.15.0, but no API breakage. Router is still using the deprecated APIs, hence we locked at 1.13.1 to avoid deprecation warnings. But now we have a peer dep issue, so damned if you do, damned if you don't...

[SeeThruHead]

@timdorr when will these apis be removed? 1.16? or 2.0?

[timdorr]

@SeeThruHead v2.0.0

[SeeThruHead]

The peerdep in react-router should then be history 1.x no?

[timdorr]

Again, we are using deprecated APIs in router and we want to avoid those from cropping up. This is the simplest way to avoid them and enforce the right version.

[SeeThruHead]

Ok so your recommended course of action is for everyone to edit the peerdep that npm saves to the package.json to be locked to a minor version? What if the user want's to upgrade to 1.15 and is ok with react-router using deprecated apis? We would then manually edit react-router peerdeps to prevent npm errors? Please advise. At a glance this seems like it might not be the best solution.

[timdorr]

We're prepping a 1.1 release that will solve the issue. We have a lot more users that will want to simply make the warnings disappear than those that want to use just-released APIs for the history subproject.

[SeeThruHead]

Understood. Thank you for the insight.