Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"module" entry point missing in v3.0.1 #4347

Closed
insin opened this issue Jan 18, 2017 · 3 comments
Closed

"module" entry point missing in v3.0.1 #4347

insin opened this issue Jan 18, 2017 · 3 comments

Comments

@insin
Copy link
Contributor

insin commented Jan 18, 2017

The "module" entry point added in this PR isn't present in the latest release's package.json, so Webpack 2 won't be able to tree shake by default.

@pshrmn
Copy link
Contributor

pshrmn commented Jan 18, 2017

It looks like it was was lost in this commit: a3dccec. I don't see a reason for its removal.

On a similar note, this also does not exist in the v4 package.json.

@mjackson
Copy link
Member

@timdorr Do you know why this was removed in v3?

As for v4, I haven't really looked into tree-shaking in webpack v2 yet. Looks like all we need to do is compile a version of our code that leaves all our import statements intact?

@timdorr
Copy link
Member

timdorr commented Jan 18, 2017

Must have been a bad merge of master back into next. I'll add it back and push a 3.0.2 to get it out there.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants