Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A FAQ #4852

Closed
pshrmn opened this issue Mar 28, 2017 · 5 comments
Closed

Add A FAQ #4852

pshrmn opened this issue Mar 28, 2017 · 5 comments

Comments

@pshrmn
Copy link
Contributor

pshrmn commented Mar 28, 2017

I think that it would be beneficial if there was a list of frequently asked questions. The type of questions that can be answered by pointing the user to existing documentation or should be handled on StackOverflow, but still show up here.

The ones that I can think of off the top of my head are:

q. Why aren't my components updating
a. link to the blocked updates guide

q. Why don't my components render after refreshing?
a. This usually is because the dev is using <BrowserRouter> with a static website

q. Why doesn't my application work when loading nested routes?
a. This usually happens when the bundled source in the script tag uses a relative path (<script src='bundle.js'> should be <script src='/bundle.js'>)

q. What happened to location.query
a. ...
(I'm not sure any answer will satisfy some people, but at least give a basic explanation of why it was removed)

@PavelPolyakov
Copy link

I assume I can suggest one more common question, the one which I met today:
reactjs/react-router-redux#179 (comment)

I think it happens to almost all who tries to connect https://github.com/gaearon/react-hot-loader to the project where the react-router is used.

I'm not sure that my solution is correct. And, actually, I would be much cooler if we can not pass any properties to the rendered component, as it's suggested in the webpack 2 example:
https://webpack.js.org/guides/hmr-react/

Thanks for the router itself!

Regards,

@pshrmn pshrmn mentioned this issue Apr 1, 2017
@hoschi
Copy link

hoschi commented Apr 10, 2017

q. What happened to location.query

was it removed? That information would be already more than nothing. I'm fine with parsing that by myself, but at the first moment I thought I just can't find it :)

@timdorr
Copy link
Member

timdorr commented Apr 10, 2017

Because it bloated the library and made assumptions about how you wanted the query string parsed. querystring, qs, and query-string all parse differently, which may or may not integrate well with other parts of your system. We don't want to form an opinion on this and then force you to take a double-hit for including two query string libraries.

@hoschi
Copy link

hoschi commented Apr 10, 2017

thanks for the explanation, sounds good

@pshrmn
Copy link
Contributor Author

pshrmn commented Apr 11, 2017

Closing because #4896 was merged. I have a draft with an answer to the location.query question, but it is a difficult thing to answer succinctly.

@pshrmn pshrmn closed this as completed Apr 11, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants