react-router-redux throws warnings with react 15.5

[ricardojoaoreis]

Version

react-router 3.0.3
react-router-redux 4.0.8

Issue

The changes in react 15.5 regarding PropTypes and createClass make react-router-redux throw two warnings.

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

Warning: RouterContext: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Will this issue be solved or is it something that will be addressed when react-router-redux 5 is released with support for react-router 4?

[simonkberg]

Sorry to nit, but these warnings do not stem from react-router-redux (current version living here), they are all from the v3 code base of react-router.

[timdorr]

Should be fixed on master. I'll see about getting a release out soon.

[simonkberg]

@timdorr this issue is regarding RR3 (which also uses the now deprecated createClass call).

If you accept PR's for the v3 branch I'd be happy to contribute.

[timdorr]

Yep, we do. I will take care of it now, though. It's not that hard to go through, luckily.

[ricardojoaoreis]

@simonkberg I noticed that the error was due to the react-router version that's why I mentioned it in the report 😉

@timdorr thanks for the speedy response and fix 👍

[thinkininfinity]

@timdorr I met the same warning with react-router@2.8.1, so whether you fixing it in 2.x version?

[timdorr]

No, we're not maintaining the 2.x versions. Upgrade to 3.x, it's just 2.x without the deprecation warnings.

[FoxxMD]

Is this change still waiting to get into the v3 branch?

[simonkberg]

@FoxxMD the fixes has been released https://github.com/ReactTraining/react-router/releases/tag/v3.0.4

[FoxxMD]

@simonkberg thanks! I didn't see it on the release page but I didn't scroll down far enough :)

[kevinguard]

@simonkberg I upgraded to 3.0.4 and am still seeing these warnings.

[simonkberg]

@kevinguard are you sure they're coming from RR? could you post the full stack trace?

[dmk23]

I just upgraded to 3.0.5, seeing the warning but they are from a different package. I guess lots of modules out there still not brought into compliance