Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - MemoryRouter and StaticRouter links don't work #5440

Closed
jlongster opened this issue Aug 18, 2017 · 2 comments
Closed

Docs - MemoryRouter and StaticRouter links don't work #5440

jlongster opened this issue Aug 18, 2017 · 2 comments

Comments

@jlongster
Copy link
Contributor

Version

4.1.1

Test Case

It's the docs website, right here: https://reacttraining.com/react-router/web/api/Router

The code for it is here: https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/api/Router.md

Steps to reproduce

Click on MemoryRouter or StaticRouter. Those links don't work on the docs website, you are taking to the root page: https://reacttraining.com/react-router/

Expected Behavior

You should be taken to the right docs page for each type of router.

Actual Behavior

It takes you to https://reacttraining.com/react-router/

I would fix it but I don't know how the docs are generated. It looks like they are relative links, whereas the others that do work are not:

- [`<BrowserRouter>`](../../../react-router-dom/docs/api/BrowserRouter.md)
- [`<HashRouter>`](../../../react-router-dom/docs/api/HashRouter.md)
- [`<MemoryRouter>`](MemoryRouter.md)
- [`<NativeRouter>`](../../../react-router-native/docs/api/NativeRouter.md)
- [`<StaticRouter>`](StaticRouter.md)

But it looks like those relative links are intentional and should keep you on the current web/native/core section.

@pshrmn
Copy link
Contributor

pshrmn commented Aug 18, 2017

Thanks, this is one of those bugs that I'm surprised no one has brought up until now.

The site uses a markdown loader that "fixes" links with dot segments in their path, so I just prepended ./ to those broken links.

@kevinzwhuang
Copy link

@pshrmn @timdorr Looks like the site needs to be rebuilt/redeployed?

I ran the react-router-website server locally on my machine and the links are fixed currently, but when I tried out the links on https://reacttraining.com/react-router/web/api/Router and the MemoryRouter and StaticRouter links are still broken.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants