Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribute compiled JS file for including in a script tag #73

Closed
lubelski opened this issue Jul 8, 2014 · 6 comments · May be fixed by micahlmartin/react-router#1
Closed

distribute compiled JS file for including in a script tag #73

lubelski opened this issue Jul 8, 2014 · 6 comments · May be fixed by micahlmartin/react-router#1

Comments

@lubelski
Copy link

lubelski commented Jul 8, 2014

Any plans to distribute this as a complied JS file suitable for including via a plain old script tag? (and then potentially served via CDN)

@zbyte64
Copy link

zbyte64 commented Jul 8, 2014

+1

I want to use this library in a standalone tutorial so having a precompiled JS file would be great...

@mjackson
Copy link
Member

This is currently really difficult for us to do because we require react/lib/invariant, react/lib/ExecutionEnvironment, and others. Currently, none of them are exposed on the React global, so we don't have access to them.

I do however agree that we should definitely have a browser build that you can drop into a <script> tag.

@mjackson
Copy link
Member

Filed facebook/react#1906 to get the React maintainers' opinion on exposing lib functions for plugins.

@mjackson
Copy link
Member

I created a build script and put some builds for version 0.2.1 in the build directory.

@rpflorence Not sure if you want to keep these with the repo or not. Feel free to move them wherever you want.

@ryanflorence
Copy link
Member

Sweet, this was on my agenda for tomorrow.

Sent from my iPhone

On Jul 21, 2014, at 5:21 PM, Michael Jackson notifications@github.com wrote:

I created a build script and put some builds for version 0.2.1 in the build directory.

@rpflorence Not sure if you want to keep these with the repo or not. Feel free to move them wherever you want.


Reply to this email directly or view it on GitHub.

@ryanflorence
Copy link
Member

I'll update some docs and cut a release tonight or tomorrow morning.

Sent from my iPhone

On Jul 21, 2014, at 5:21 PM, Michael Jackson notifications@github.com wrote:

I created a build script and put some builds for version 0.2.1 in the build directory.

@rpflorence Not sure if you want to keep these with the repo or not. Feel free to move them wherever you want.


Reply to this email directly or view it on GitHub.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants