-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile safari triggers Router.run twice on initial page load #753
Comments
interesting, let us know if you discover anything else. |
I think this is a WebKit bug. See https://bugs.webkit.org/show_bug.cgi?id=93506 @bmcmahen Are you using Also, Twitter worked around this bug by ignoring |
Yep, I was using |
Still getting onPopState event on initial page load with Safari 8.0.6. Check should be changed from |
I think this needs to be re-opened as I am still seeing this issue. Following @dlindenkreuz suggestion, I changes that if to: if (event.state === undefined || event.state === null) {
return;
} and it seems to work in safari after that. |
I haven't had too much time to test this in other contexts, but within my app I've noticed that on the initial page load
Router.run
is triggered twice on the initial page load -- both times with the same state / route information. I haven't noticed this happening in any other browsers. As a quick fix, I've stored the current route information and done the relevant checks to determine if it has, indeed, changed.The text was updated successfully, but these errors were encountered: