Bug: props.activeRoute does not render

[jasonkuhrt]

Strange issue:

I had a root Route handler like this:

var App = React.createClass({
  displayName: 'App',
  render: function(){
    return  E.p(null,
              Router.Link({ to:'dashboard' }, 'dashboard'),
              Router.Link({ to:'intro' }, 'intro'),
              this.props.activeRoute
            )
  }
})

This worked fine when loading the page at / and navigating from there. But if I loaded the page at e.g. /#/dashboard then dashboard is not rendered... (but oddly if I console.log(this.props.activeRoute) it does have value!. My workaround is to use App handler for basically just returning this.props.activeRoute or a temporary DOM node:

var App = React.createClass({
  displayName: 'App',
  render: function(){
    if (this.props.activeRoute) return this.props.activeRoute
    return  E.div()
  }
})

[ryanflorence]

What does your route config look like, and your dashboard handler?

[jasonkuhrt]

@rpflorence Here is the code:

var App = React.createClass({
  displayName: 'App',
  render: function(){
    return  E.p(null,
              Router.Link({ to:'dashboard' }, 'dashboard'),
              Router.Link({ to:'intro' }, 'intro'),
              this.props.activeRoute
            )
  }
})

var viewDashboard = React.createClass({
  displayName: 'dashboard',
  render: function(){
    return E.p(null, 'a!')
  }
})

var viewIntro = React.createClass({
  displayName: 'intro',
  render: function(){
    return E.p(null, 'intro!')
  }
})

var routes =  Route({ handler: App },
                Route({ name: 'intro', handler: viewIntro }),
                Route({ name: 'dashboard', handler: viewDashboard })
              )

doc_ready(function(){
  React.renderComponent(routes, document.body)
})

The issue is that I was nesting views into a p element! Again some error feedback would have been helpful but ultimately there is no bug in RNR here, sorry : )

[ryanflorence]

Perhaps react could tell you your HTML is invalid, but certainly not the router :) glad you tracked it down.

[jasonkuhrt]

but certainly not the router :)

Yeah of course, @spicyj then