Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qs arrayFormat configuration #901

Closed
willbutler opened this issue Mar 2, 2015 · 2 comments
Closed

qs arrayFormat configuration #901

willbutler opened this issue Mar 2, 2015 · 2 comments

Comments

@willbutler
Copy link

Line 149 of PathUtils.js currently calls stringify with {indices: false}, which forces the qs arrayFormat to 'repeat.' It would be great if we could specify the arrayFormat when configuring react-router.
@willbutler
Copy link
Author

It appears that this request depends on a yet to be released version of qs (v2.3.4).

@mjackson
Copy link
Member

mjackson commented Mar 2, 2015

Yes, I made the PR that introduced the arrayFormat option. When qs ships a stable release with that option we'll use arrayFormat: "brackets". I'll leave this open to remind me to do it :)

@davidtheclark davidtheclark mentioned this issue Apr 16, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjackson @willbutler