chore: update issue link checks (#3)

Signed-off-by: Logan McAnsh <logan@mcan.sh>
remix-run · Mar 24, 2023 · 547ad6a · 547ad6a
1 parent 56889a0
commit 547ad6a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -7229,7 +7229,9 @@ async function findMergedPRs(commits) {
 }
 function isReferencedResult(result) {
     let isNode = (node) => {
-        return typeof node === "object" && typeof node.number === "number";
+        return typeof node === "object" && node.number
+            ? typeof node.number === "number"
+            : true;
     };
     let isPageInfo = (pageInfo) => {
         return (typeof pageInfo === "object" &&

diff --git a/src/index.ts b/src/index.ts
@@ -268,28 +268,32 @@ async function findMergedPRs(commits: Array<string>): Promise<MergedPR[]> {
   return result.filter((pr: any): pr is MergedPR => pr != undefined);
 }
 
+type ReferencedIssueResultNodes = Array<{ number: number }>;
+type ReferencedIssueResultPageInfo = {
+  hasNextPage: boolean;
+  endCursor: string;
+};
 type ReferencedIssueResult = {
   data: {
     resource: {
       closingIssuesReferences: {
-        nodes: Array<{ number: number }>;
-        pageInfo: {
-          hasNextPage: boolean;
-          endCursor: string;
-        };
+        nodes: ReferencedIssueResultNodes;
+        pageInfo: ReferencedIssueResultPageInfo;
       };
     };
   };
 };
 
 function isReferencedResult(result: any): result is ReferencedIssueResult {
-  let isNode = (node: any): node is { number: number } => {
-    return typeof node === "object" && typeof node.number === "number";
+  let isNode = (node: any): node is ReferencedIssueResultNodes => {
+    return typeof node === "object" && node.number
+      ? typeof node.number === "number"
+      : true;
   };
 
   let isPageInfo = (
     pageInfo: any
-  ): pageInfo is { hasNextPage: boolean; endCursor: string } => {
+  ): pageInfo is ReferencedIssueResultPageInfo => {
     return (
       typeof pageInfo === "object" &&
       typeof pageInfo.hasNextPage === "boolean" &&
@@ -299,10 +303,7 @@ function isReferencedResult(result: any): result is ReferencedIssueResult {
 
   let isClosingIssuesReferences = (
     closingIssuesReferences: any
-  ): closingIssuesReferences is {
-    nodes: Array<{ number: number }>;
-    pageInfo: { hasNextPage: boolean; endCursor: string };
-  } => {
+  ): closingIssuesReferences is ReferencedIssueResult => {
     return (
       typeof closingIssuesReferences === "object" &&
       typeof closingIssuesReferences.nodes === "object" &&