This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
Fix safari login issue #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Safari login does not work for me locally (without any extensions) if secure is set to true. This change will only set it to true only if the node environment is production.
|
Thanks for the PR. We're archiving this repository in favor of the project example here: https://github.com/remix-run/remix/tree/main/examples/jokes If you feel this is still a PR that needs to be merged, feel free to make the same change to the project in the examples directory. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari login does not work for me locally (without any extensions) if secure is set to true. This change will only set it to true only if the node environment is production.