Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create meta tag helper function #113

Closed
brookslybrand opened this issue Oct 13, 2023 · 3 comments
Closed

Create meta tag helper function #113

brookslybrand opened this issue Oct 13, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@brookslybrand
Copy link
Contributor

Would be nice to have a common set of meta tags that we can use/extend. Maybe just a simple function with some defaults.

The main page (_marketing._index.tsx) has a nice set of defaults

export const meta: MetaFunction<typeof loader> = (args) => {
  let { siteUrl } = args.data || {};
  let title = "Remix - Build Better Websites";
  let image = siteUrl ? `${siteUrl}/img/og.1.jpg` : null;
  let description =
    "Remix is a full stack web framework that lets you focus on the user interface and work back through web standards to deliver a fast, slick, and resilient user experience. People are gonna love using your stuff.";
  return metaV1(args, {
    title,
    description,
    "og:url": siteUrl,
    "og:title": title,
    "og:description": description,
    "og:image": image,
    "twitter:card": "summary_large_image",
    "twitter:creator": "@remix_run",
    "twitter:site": "@remix_run",
    "twitter:title": title,
    "twitter:description": description,
    "twitter:image": image,
  });
};

I think we could possibly just extend this.

@brookslybrand brookslybrand added the good first issue Good for newcomers label Jan 23, 2024
@Kazuhiro-Mimaki
Copy link
Contributor

Since the PR related to this issue has been merged, I think this issue should be closed.

@brookslybrand
Copy link
Contributor Author

@Kazuhiro-Mimaki thanks for pointing this out. The meta tags aren't completely cleaned up, but this was a good first step. I'll update the description of this issue, close it, and then create a new ticket for the remaining work

@brookslybrand brookslybrand changed the title Cleanup meta tags Create meta tag helper function Feb 28, 2024
@brookslybrand
Copy link
Contributor Author

See #214 for remaining work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants