Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @remix-run/v1-meta #214

Closed
brookslybrand opened this issue Feb 28, 2024 · 0 comments · Fixed by #226
Closed

Remove @remix-run/v1-meta #214

brookslybrand opened this issue Feb 28, 2024 · 0 comments · Fixed by #226
Labels
good first issue Good for newcomers

Comments

@brookslybrand
Copy link
Contributor

@Kazuhiro-Mimaki added a getMeta function in #196 which makes it much easier to add meta tags to various pages.

This function should also make it much easier to remove @remix-run/v1-meta usage and lean fully into the v2 convention

There are 20 places we use the metaV1.

This issue can definitely be broken into multiple PRs, no need to try to migrate all of the places all at once. In fact, it will be much easier for me to review if it is broken up over a few PRs.

Be sure check that the meta tags look the same before and after the change, and that new tags are only introduced when it makes sense (for example, returning meta for a 404 probably shouldn't include <meta name="twitter:card" content="summary_large_image">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant