perf(remix-architect): Performance improvements on isBinaryType

contributors.yml

@@ -151,6 +151,7 @@
 - guatedude2
 - guerra08
 - gunners6518
+- gyx1000
 - hadizz
 - hardingmatt
 - helderburato

packages/remix-architect/__tests__/binaryType-test.ts

@@ -0,0 +1,11 @@
+import { isBinaryType } from "../binaryTypes";
+
+describe('architect isBinaryType', () => {
+  it('should detect binary contentType correctly', () => {
+    expect(isBinaryType(undefined)).toBe(false);
+    expect(isBinaryType(null)).toBe(false);
+    expect(isBinaryType('text/html; charset=utf-8')).toBe(false);
+    expect(isBinaryType('application/octet-stream')).toBe(true);
+    expect(isBinaryType('application/octet-stream; charset=test')).toBe(true);
+  });
+});

packages/remix-architect/binaryTypes.ts

@@ -2,7 +2,7 @@
  * Common binary MIME types
  * @see https://github.com/architect/functions/blob/45254fc1936a1794c185aac07e9889b241a2e5c6/src/http/helpers/binary-types.js
  */
-const binaryTypes = [
+const binaryTypes = new Set([
   "application/octet-stream",
   // Docs
   "application/epub+zip",
@@ -60,9 +60,10 @@ const binaryTypes = [
   "application/x-tar",
   "application/x-zip",
   "application/zip",
-];
+]);
 
 export function isBinaryType(contentType: string | null | undefined) {
   if (!contentType) return false;
-  return binaryTypes.some((t) => contentType.includes(t));
+  let [ test ] = contentType.split(';');
+  return binaryTypes.has(test);
 }