Use includes instead of has

remix-run · Dec 14, 2022 · aed9912 · aed9912
1 parent 0b14a9d
commit aed9912
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.changeset/late-bottles-shop.md b/.changeset/late-bottles-shop.md
@@ -6,4 +6,4 @@
 
 improve performance of `isBinaryType` in the netlify and architect adapters
 
-previous implementation from arc itself has a complexity of O(N*includesComplexity), where as now it is O(1).
+previous implementation from arc itself has a complexity of O(N*includesComplexity), where as now it is O(includesComplexity).
diff --git a/packages/remix-architect/binaryTypes.ts b/packages/remix-architect/binaryTypes.ts
@@ -2,7 +2,7 @@
  * Common binary MIME types
  * @see https://github.com/architect/functions/blob/45254fc1936a1794c185aac07e9889b241a2e5c6/src/http/helpers/binary-types.js
  */
-const binaryTypes = new Set([
+const binaryTypes = [
   "application/octet-stream",
   // Docs
   "application/epub+zip",
@@ -60,10 +60,10 @@ const binaryTypes = new Set([
   "application/x-tar",
   "application/x-zip",
   "application/zip",
-]);
+];
 
 export function isBinaryType(contentType: string | null | undefined) {
   if (!contentType) return false;
   let [test] = contentType.split(";");
-  return binaryTypes.has(test);
+  return binaryTypes.includes(test);
 }
diff --git a/packages/remix-netlify/binaryTypes.ts b/packages/remix-netlify/binaryTypes.ts
@@ -2,7 +2,7 @@
  * Common binary MIME types
  * @see https://github.com/architect/functions/blob/45254fc1936a1794c185aac07e9889b241a2e5c6/src/http/helpers/binary-types.js
  */
-const binaryTypes = new Set([
+const binaryTypes = [
   "application/octet-stream",
   // Docs
   "application/epub+zip",
@@ -60,10 +60,10 @@ const binaryTypes = new Set([
   "application/x-tar",
   "application/x-zip",
   "application/zip",
-]);
+];
 
 export function isBinaryType(contentType: string | null | undefined) {
   if (!contentType) return false;
   let [test] = contentType.split(";");
-  return binaryTypes.has(test);
+  return binaryTypes.includes(test);
 }