Skip to content

Commit

Permalink
Merge branch 'dev' into brophdawg11/pathless-route-collision-3
Browse files Browse the repository at this point in the history
  • Loading branch information
brophdawg11 committed May 22, 2023
2 parents cf00df9 + d56574b commit fc33f83
Show file tree
Hide file tree
Showing 141 changed files with 913 additions and 455 deletions.
6 changes: 0 additions & 6 deletions .changeset/afraid-coats-count.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/better-opt-out-of-revalidations.md

This file was deleted.

6 changes: 0 additions & 6 deletions .changeset/big-carrots-attend.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/calm-falcons-boil.md

This file was deleted.

6 changes: 0 additions & 6 deletions .changeset/eslint-no-display-name.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/export-use-match.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/expose-error-headers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/server-runtime": minor
---

Add `errorHeaders` parameter to the leaf `headers()` function to expose headers from thrown responses that bubble up to ancestor route boundaries. If the throwing route contains the boundary, then `errorHeaders` will be the same object as `loaderHeaders`/`actionHeaders` for that route.
5 changes: 0 additions & 5 deletions .changeset/five-poems-stare.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/good-laws-marry.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/include-css-bundle-in-manifest-hash.md

This file was deleted.

24 changes: 24 additions & 0 deletions .changeset/lemon-beers-fetch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
"@remix-run/server-runtime": minor
"@remix-run/react": minor
---

Force Typescript to simplify type produced by `Serialize`.

As a result, the following types and functions have simplified return types:
- SerializeFrom
- useLoaderData
- useActionData
- useFetcher

```ts
type Data = { hello: string; when: Date }

// BEFORE
type Unsimplified = SerializeFrom<Data>
// ^? SerializeObject<UndefinedToOptional<{ hello: string; when: Date }>>

// AFTER
type Simplified = SerializeFrom<Data>
// ^? { hello: string; when: string }
```
6 changes: 0 additions & 6 deletions .changeset/light-bikes-exercise.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/polite-garlics-invite.md

This file was deleted.

8 changes: 0 additions & 8 deletions .changeset/poor-nails-warn.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/slimy-snakes-do.md

This file was deleted.

6 changes: 0 additions & 6 deletions .changeset/tsconfig-no-modify.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/twenty-toys-laugh.md

This file was deleted.

6 changes: 0 additions & 6 deletions .changeset/update-babel.md

This file was deleted.

6 changes: 0 additions & 6 deletions .changeset/v2-meta-loader-data-type.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/young-dingos-sleep.md

This file was deleted.

24 changes: 23 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ module.exports = {
"plugin:markdown/recommended",
],
plugins: ["markdown"],
settings: {
"import/internal-regex": "^~/",
},
overrides: [
{
files: ["**/*.md/**"],
Expand All @@ -28,10 +31,29 @@ module.exports = {
},
},
{
files: ["templates/**/*.*"],
files: [
"**/*.md/*.js?(x)",
"**/*.md/*.ts?(x)",
"integration/helpers/cf-template/**/*.*",
"integration/helpers/deno-template/**/*.*",
"integration/helpers/node-template/**/*.*",
"packages/remix-dev/config/defaults/**/*.*",
"templates/**/*.*",
],
rules: {
"prefer-let/prefer-let": OFF,
"prefer-const": WARN,

"import/order": [
WARN,
{
alphabetize: { caseInsensitive: true, order: "asc" },
groups: ["builtin", "external", "internal", "parent", "sibling"],
"newlines-between": "always",
},
],

"react/jsx-no-leaked-render": [WARN, { validStrategies: ["ternary"] }],
},
},
],
Expand Down
25 changes: 21 additions & 4 deletions .github/workflows/deployments.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,15 @@ on:
TEST_VERCEL_USER_ID:
required: true

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
arc_deploy:
name: Architect Deploy
if: github.repository == 'remix-run/remix'
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3

Expand Down Expand Up @@ -72,6 +71,9 @@ jobs:
if: github.repository == 'remix-run/remix'
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3

Expand Down Expand Up @@ -107,6 +109,9 @@ jobs:
if: github.repository == 'remix-run/remix'
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3

Expand Down Expand Up @@ -143,6 +148,9 @@ jobs:
if: github.repository == 'remix-run/remix'
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3

Expand Down Expand Up @@ -182,6 +190,9 @@ jobs:
if: github.repository == 'remix-run/remix'
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3

Expand Down Expand Up @@ -217,6 +228,9 @@ jobs:
if: github.repository == 'remix-run/remix'
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3

Expand Down Expand Up @@ -249,6 +263,9 @@ jobs:
if: github.repository == 'remix-run/remix'
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3

Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,15 @@ on:
- main
- dev

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
format:
if: github.repository == 'remix-run/remix'
runs-on: ubuntu-latest

steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3
with:
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ on:
- dev
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
lint:
name: ⬣ Lint
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3

Expand Down
29 changes: 29 additions & 0 deletions .github/workflows/merged-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: 📦 Merged PR

on:
pull_request:
types: [closed]
branches:
- dev
paths:
- "packages/**"

permissions:
pull-requests: write

jobs:
merged:
name: Add label to merged PR
if: github.event.pull_request.merged == true && github.repository == 'remix-run/remix'
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v6
with:
retries: 3
script: |
await github.issues.addLabels({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
labels: 'awaiting release',
})
7 changes: 3 additions & 4 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ on:
schedule:
- cron: "0 7 * * *" # every day at 12AM PST

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
CI: true

Expand All @@ -26,6 +22,9 @@ jobs:
# allows this to be used in the `comment` job below - will be undefined if there's no release necessary
NEXT_VERSION: ${{ steps.version.outputs.NEXT_VERSION }}
steps:
- name: 🛑 Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v3
with:
Expand Down
29 changes: 11 additions & 18 deletions .github/workflows/no-response.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,18 @@ jobs:
- name: 🥺 Handle Ghosting
uses: actions/stale@v8
with:
days-before-close: 10
close-issue-message: >
This issue has been automatically closed because we didn't hear
anything from the original author after the previous notice.
This issue has been automatically closed because we haven't received a
response from the original author 🙈. This automation helps keep the issue
tracker clean from issues that are unactionable. Please reach out if you
have more information for us! 🙂
close-pr-message: >
This PR has been automatically closed because we didn't hear
anything from the original author after the previous notice.
This PR has been automatically closed because we haven't received a
response from the original author 🙈. This automation helps keep the issue
tracker clean from PRs that are unactionable. Please reach out if you
have more information for us! 🙂
# don't automatically mark issues/PRs as stale
days-before-stale: -1
stale-issue-label: needs-response
stale-issue-message: >
This issue has been automatically marked stale because we haven't
received a response from the original author in a while 🙈. This
automation helps keep the issue tracker clean from issues that are
not actionable. Please reach out if you have more information for us
or you think this issue shouldn't be closed! 🙂 If you don't do so
within 7 days, this issue will be automatically closed.
stale-pr-label: needs-response
stale-pr-message: >
This PR has been automatically marked stale because we haven't
received a response from the original author in a while 🙈. This
automation helps keep the issue tracker clean from issues that are
not actionable. Please reach out if you have more information for us
or you think this issue shouldn't be closed! 🙂 If you don't do so
within 7 days, this PR will be automatically closed.

0 comments on commit fc33f83

Please sign in to comment.