Default ESLint config with typescript should include typescript-eslint:recommended(-requiring-type-checking)

[JoshuaKGoldberg]

Similar to #5071, but for projects that enable TypeScript. Right now, Remix projects created with npx create-remix@latest and TypeScript use the TSESLint parser for TypeScript projects -great!- but haven't enabled any of its preset configurations. Those configurations are recommended for most-to-all TypeScript projects by the TSESLint maintenance team.

To verify the list of ESLint rules used in an app newly created with create-remix --typescript, you can run:

npx eslint --print-config app/routes/_index.tsx > rules.json

Is there a particular reason not to include the @typescript-eslint/recommended and @typescript-eslint/recommended-requiring-type-checking configs for users by default?

A couple of notes on why that's likely more desirable now than in the past:

• The recommended configs should no longer contain opinionated rules that wouldn't be good in most projects
• If there are still overly chafe-y rules, we're gearing up for a 6.X release and would be happy to move those to the new strict configuration

Proposed solution:

1. Make a @remix-run/typescript lint config in @remix-run/eslint-config that extends from @typescript-eslint/recommended and @typescript-eslint/recommended-requiring-type-checking
2. In create-remix, when TypeScript is provided, change the .eslintrc.json file contents to include "@remix-run/typescript" in extends.

Edit based on #6126 (comment): there's already a typescript set of overrides! So this discussion should be around enabling recommended rules in them.

[MichaelDeBoey]

As you can see in the default config, we're already including TypeScript rules

remix/packages/remix-eslint-config/index.js

Line 77 in 66b39d1

...typescriptRules,

remix/packages/remix-eslint-config/rules/typescript.js

Lines 5 to 54 in 66b39d1

	module.exports = {
	"no-dupe-class-members": OFF,
	"no-undef": OFF,
	// Add TypeScript specific rules (and turn off ESLint equivalents)
	"@typescript-eslint/consistent-type-assertions": WARN,
	"@typescript-eslint/consistent-type-imports": WARN,
	"no-array-constructor": OFF,
	"@typescript-eslint/no-array-constructor": WARN,
	// There is a bug w/ @typescript-eslint/no-duplicate-imports triggered
	// by multiple imports inside of module declarations. We should reenable
	// this rule when the bug is fixed.
	// https://github.com/typescript-eslint/typescript-eslint/issues/3071
	"no-duplicate-imports": OFF,
	// "@typescript-eslint/no-duplicate-imports": WARN,
	"no-redeclare": OFF,
	"@typescript-eslint/no-redeclare": ERROR,
	"no-use-before-define": OFF,
	"@typescript-eslint/no-use-before-define": [
	WARN,
	{
	functions: false,
	classes: false,
	variables: false,
	typedefs: false,
	},
	],
	"no-unused-expressions": OFF,
	"@typescript-eslint/no-unused-expressions": [
	WARN,
	{
	allowShortCircuit: true,
	allowTernary: true,
	allowTaggedTemplates: true,
	},
	],
	"no-unused-vars": OFF,
	"@typescript-eslint/no-unused-vars": [
	WARN,
	{
	args: "none",
	ignoreRestSiblings: true,
	},
	],
	"no-useless-constructor": OFF,
	"@typescript-eslint/no-useless-constructor": WARN,
	};

So I don't think we need an extra typescript entry point tbh.

If you want to extend the configs you mentioned by default, I would suggest to create a PR that does so and then the team will look into if it's desired or not.

[JoshuaKGoldberg]

So I don't think we need an extra typescript entry point tbh.

Aha excellent! Apologies, I'd missed this. I'll edit the OP to make it more clear that the right proposal is augmenting the existing config, not crafting a new config.

already including TypeScript rules

It's including some TypeScript rules, yes. But there are dozens of other rules that come with each of plugin:@typescript-eslint/recommended and the other configs. The Remix Typescript config right now has fewer than a dozen enabled. It's missing out!

(apologies if you already know this - just posting for visibility, as this has been a frequent area of confusion for users)

[brophdawg11]

#6614 is merged so this should be resolve din the next release (1.18.0)

[JoshuaKGoldberg]

Amazing, thanks @brophdawg11! I really appreciate you & co. working with me on this. And I'll send a PR with typescript-eslint v6 improvements, too, once we get it out the door!