Incorrect sourceMappingURL added to generated server bundle prevents debugging

[kiliman]

Updated my gist with patch to use sourcemap: 'inline'. This solves the issue.

Here's the gist:
https://gist.github.com/kiliman/a9d7c874af03369a1d105a92560d89e9

[ryanflorence]

I've also confirmed it's using the remix publicPath to generate that URL, which isn't right, but since we don't get to configure the path in esbuild (we just say sourcemap: true) we might want to either:

1. use "inline" for the server build
2. use "external" for the server build and then append the URL ourselves

Or there's some configuration that I'm unaware of that we're doing wrong in our esbuild server bundle.

[zigomir]

Pasting this here for context: evanw/esbuild#1290

Changing sourcemap: true, to sourcemap: 'inline', in createServerBuild` works. If I open PR for it is it something you'd accept?

[kiliman]

I've updated my gist to add a patch for sourcemap to inline. Hopefully the PR will make it in.

https://gist.github.com/kiliman/a9d7c874af03369a1d105a92560d89e9

[kiliman]

Yes, PR #2065 fixes this as well as enables breakpoint debugging without any hacks.

[connor4312]

By the way, you can also make breakpoints work by doing something like this in your launch.json within VS Code:

    {
      "type": "node-terminal",
      "request": "launch",
      "name": "Launch Server",
      "command": "npm run dev:remix",
      "skipFiles": ["<node_internals>/**"],
      "sourceMapPathOverrides": {
        "route:*": "*" // <-- fix up the paths, so route:<path> just becomes <path>
      },
      "outFiles": ["${workspaceFolder}/build/**/*.js"]
    },

    {
      "name": "Launch Client",
      "request": "launch",
      "type": "msedge",
      "url": "http://localhost:3000",
      "webRoot": "${workspaceFolder}/public/build" // tell the debugger that relative sourcemaps paths should be resolved from here
    }

Aside from having to fix the route: this is fairly 'idiomatic', though not easy to discover unless you're a sourcemapexpert... microsoft/vscode-js-debug#1214

[kiliman]

Thanks. TIL

[machour]

Fixed in #2065 🎉

[github-actions]

🤖 Hello there,

We just published version v1.3.5-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[heiso]

Hi there ! Thanks for the amazing work.

Where can i find the documentation about enabling sourcemaps in dev mode ?

I'm trying things but nothing seems to work T_T

[kiliman]

@heiso Are you on the latest Remix? Sourcemaps should automatically generate in development. You have to opt-in to sourcemaps for production remix build --sourcemap

They removed the sourcemap option in remix.config