Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of TypeScript 4.9 satisfies breaks build process #4639

Closed
LunarMelody opened this issue Nov 18, 2022 · 9 comments · Fixed by #4301
Closed

Use of TypeScript 4.9 satisfies breaks build process #4639

LunarMelody opened this issue Nov 18, 2022 · 9 comments · Fixed by #4301
Labels
bug Something isn't working feat:typescript

Comments

@LunarMelody
Copy link

What version of Remix are you using?

1.7.6

Steps to Reproduce

  1. Create Remix app with yarn/your tool, I used blues stack
  2. Install TypeScript 4.9.3
  3. Create a type, something like
type SomethingCool = {
  foo: number;
}
  1. Try to create an object and use the new satisfies keyword with SomethingCool
  2. Try to build

Expected Behavior

The project builds

Actual Behavior

The project doesn't build and there's an error being thrown

$ remix build
Building Remix app in production mode...

✘ [ERROR] [plugin browser-route-module] Build failed with 1 error:
app/root.tsx:32:4: ERROR: Expected ";" but found "satisfies"
@jenseng
Copy link
Contributor

jenseng commented Nov 18, 2022

Likely just need to bump esbuild to 0.15.13+

@machour
Copy link
Collaborator

machour commented Nov 18, 2022

Oh perfect, then #4301 should fix this too!

@machour machour linked a pull request Nov 18, 2022 that will close this issue
2 tasks
@pcattori
Copy link
Contributor

Update: #4301 upgrades esbuild to 0.15.12. We were seeing tests hang or fail on 0.15.13+. We're working on fixing the underlying issues and then will upgrade to 0.15.13+

@machour machour added the awaiting release This issue has been fixed and will be released soon label Nov 18, 2022
@MichaelDeBoey
Copy link
Member

Closed by #4301

@pcattori
Copy link
Contributor

@MichaelDeBoey we still haven't upgraded esbuild to 0.15.13+, so #4301 does not actually address this. I've edited the description of #4301 to make that more clear.

@pcattori pcattori reopened this Nov 19, 2022
@MichaelDeBoey
Copy link
Member

@pcattori Oh didn't know we reverted it to 0.15.12 again, I thought we were using 0.15.14 🙈

@machour machour removed the awaiting release This issue has been fixed and will be released soon label Nov 19, 2022
@JClackett
Copy link

What's the latest with this? still getting:

Expected ";" but found "satisfies"

when running remix build

using:
remix: 1.8.0
esbuild: 0.15.16

@pcattori
Copy link
Contributor

pcattori commented Dec 2, 2022

We're actively working on it, see #4754 .

Currently, the esbuild upgrade is causing some integration tests to hang indefinitely.
Once we have that fixed, we'll proceed with the upgrade to esbuild 0.15.13+.

@pcattori
Copy link
Contributor

pcattori commented Dec 9, 2022

#4754 is merged. This should be fixed in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat:typescript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants