Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(remix-dev): bump esbuild to 0.15.12 #4301

Merged
merged 2 commits into from
Nov 18, 2022
Merged

chore(remix-dev): bump esbuild to 0.15.12 #4301

merged 2 commits into from
Nov 18, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Sep 29, 2022 •
edited by pcattori

Closes: #4154
Closes: #4280
Closes: #4346

  • Docs
  • Tests

Testing Strategy (for esbuild native pnp support): https://github.com/mcansh/remix-pnp-test

testable pre-release 0.0.0-experimental-aed5bfbf7

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022 •
edited

🦋 Changeset detected

Latest commit: 2998b40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Sep 29, 2022 •
edited

Once this PR is merged, we can merge #4154 as well

Or if you want, you can just update + merge that one as well 🤷‍♂️

@mcansh mcansh marked this pull request as ready for review October 17, 2022 17:24
MichaelDeBoey
MichaelDeBoey requested changes Oct 17, 2022
View reviewed changes
packages/create-remix/package.json Outdated Show resolved Hide resolved
@lensbart lensbart mentioned this pull request Oct 17, 2022
Closed
MichaelDeBoey
MichaelDeBoey requested changes Oct 18, 2022
View reviewed changes
.vscode/deno_resolve_npm_imports.json Outdated Show resolved Hide resolved
templates/deno/.vscode/resolve_npm_imports.json Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 27, 2022
Closed
2 tasks
@machour machour mentioned this pull request Nov 2, 2022
Closed
@alisd23 alisd23 mentioned this pull request Nov 13, 2022
Closed
@MichaelDeBoey
Copy link
Member

@mcansh It appears @pcattori's changes weren't changed to the new esbuild version (without the extra Yarn PnP plugin)

@machour machour mentioned this pull request Nov 18, 2022
Closed
@machour machour linked an issue Nov 18, 2022 that may be closed by this pull request
Use of TypeScript 4.9 satisfies breaks build process #4639
Closed
@machour
Copy link
Collaborator

machour commented Nov 18, 2022

@mcansh Added #4301 to the list of issues that will be fixed by this PR.

@mcansh
Copy link
Collaborator Author

mcansh commented Nov 18, 2022 •
edited by MichaelDeBoey

@mcansh Added #4301 to the list of issues that will be fixed by this PR.

that's this PR haha 🙈, but i think you meant #4639 👍

@mcansh
chore(remix-dev): bump esbuild to latest
5f07560 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: downgrade to esbuild@0.15.12 until stdout/stderr tests are res…
2998b40 
…olved

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh changed the title chore(remix-dev): bump esbuild to latest chore(remix-dev): bump esbuild to 0.15.12 Nov 18, 2022
@mcansh mcansh merged commit 539b10c into dev Nov 18, 2022
@mcansh mcansh deleted the logan/esbuild-0.15.9 branch November 18, 2022 20:58
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Nov 18, 2022
@machour machour mentioned this pull request Nov 18, 2022
Closed
2 tasks
This was referenced Nov 19, 2022
Closed
Closed
kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
@mcansh @kentcdodds
chore(remix-dev): bump esbuild to 0.15.12 (#4301)
5d34003 
* chore(remix-dev): bump esbuild to latest

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* chore: downgrade to esbuild@0.15.12 until stdout/stderr tests are resolved

Signed-off-by: Logan McAnsh <logan@mcan.sh>

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh mentioned this pull request Jan 21, 2023
Closed
@MichaelDeBoey MichaelDeBoey added the pm:yarn3 Bugs related to Yarn 3 label Aug 15, 2023
@pcattori pcattori mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@pcattori pcattori pcattori approved these changes

Assignees
No one assigned
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev pm:yarn3 Bugs related to Yarn 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of TypeScript 4.9 satisfies breaks build process
4 participants
@mcansh @MichaelDeBoey @machour @pcattori