-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@apollo/client
always suggested to be added to serverDependenciesToBundle
config (even if already added)
#5483
Comments
I have the same thing, but, now that I think about it.. it might be the inner packages.. like |
I had to add all the internal dependencies individually, run |
This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this issue will be automatically closed. |
Still a thing |
This seems to be occuring for the ESM package |
Same problem here. |
My workaround is to include |
#6916 removed false-positive ESM warnings seen here |
What version of Remix are you using?
1.13.0
Are all your remix dependencies & dev-dependencies using the same version?
Steps to Reproduce
Here a reproduction repository:
https://codesandbox.io/p/sandbox/relaxed-sea-qmnf15?selection=%5B%7B%22endColumn%22%3A29%2C%22endLineNumber%22%3A9%2C%22startColumn%22%3A3%2C%22startLineNumber%22%3A9%7D%5D&file=%2Fremix.config.js
Expected Behavior
Do not suggest
@apollo/client
package as an ESM only package as it seems to export a CommonJS version.Actual Behavior
With or without
@apollo/client
in theserverDependenciesToBundle
config Remix is printing message in the console that lead to nowhere.Without
@apollo/client
in theserverDependenciesToBundle
When you start the dev server (or the make a build):
Even if
@apollo/client
seems to be CJS compatible, Remix propose to add to theserverDependenciesToBundle
config.With
@apollo/client
in theserverDependenciesToBundle
When you start the dev server (or the make a build):
The
@apollo/client
package is suggested again (but should not).The text was updated successfully, but these errors were encountered: