Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support og tags in route meta functions #88

Closed
hsiaoa opened this issue Feb 1, 2021 · 1 comment
Closed

Support og tags in route meta functions #88

hsiaoa opened this issue Feb 1, 2021 · 1 comment

Comments

@hsiaoa
Copy link

hsiaoa commented Feb 1, 2021

current implementation supports normal meta tags:

export function meta() {
  return {
    title: 'title',
    description: 'gogogo',
    'og:url': 'https://...'
  };
}

the above gives <meta name="og:url" content="https://...">

where correct og tags look like <meta property="og:url" content="https://...">

@machour
Copy link
Collaborator

machour commented Mar 15, 2022

Fixed in https://github.com/remix-run/remix/releases/tag/v0.13.0, using "og:bar": "baz" generates:

<meta property="og:bar" content="baz"/>

https://remix.run/docs/en/v1/api/conventions#meta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants