Re: @remix-run/serve sets high max-age and immutable cache header on everything

[kenteramin]

Reproduction

1. Create a remix app
2. Run build then start
3. Open the page
4. Check the headers on the /favicon.ico request

The favicon from /public comes with Cache-Control: public, max-age=31536000, immutable

System Info

remix 2.9.1

Used Package Manager

npm

Expected Behavior

The server config from
https://github.com/remix-run/remix/blob/main/packages/remix-serve/cli.ts
says app.use(express.static("public", { maxAge: "1h" }));.
So it is expected to have maxAge=1h

Actual Behavior

We actually get an immutable maxAge=1y

[kenteramin]

There was already a bug of the same nature
#903

[kenteramin]

So, actually the problem is that here

app.use(
  build.publicPath,
  express.static(build.assetsBuildDirectory, {
    immutable: true,
    maxAge: "1y",
  })
);
app.use(express.static("public", { maxAge: "1h" }));

build.assetsBuildDirectory is just build/client, so it handles all the requests to the public folder.

The config should actually be something like this

app.use(
  build.publicPath,
  express.static(build.assetsBuildDirectory + "/assets", {
    immutable: true,
    maxAge: "1y",
  })
);
app.use(express.static(build.assetsBuildDirectory, { maxAge: "1h" }));