[Bug]: @remix-run/serve sets high max-age and immutable cache header on everything

[sheepsteak]

Which Remix packages are impacted?

• remix (Remix core)
• create-remix
• @remix-run/architect
• @remix-run/cloudflare-workers
• @remix-run/dev
• @remix-run/express
• @remix-run/netlify
• @remix-run/node
• @remix-run/react
• @remix-run/serve
• @remix-run/server-runtime
• @remix-run/vercel

What version of Remix are you using?

1.0.4

What version of Node are you using? Minimum supported version is 14.

16.13.0

Steps to Reproduce

• Build and start an application in production that has some resources in the public (remix blog)
• See in dev tools that everything in public folder is served with a high max-age and immutable

Expected Behavior

Only files in public/build should have long, immutable caching as they are fingerprinted. The express starter template separates the two (although it has issues with the ordering of express.static as shown in #677 and fixed in #678):

remix/packages/create-remix/templates/express/server/index.js

Lines 13 to 17 in 57949fe

	// You may want to be more aggressive with this caching
	app.use(express.static("public", { maxAge: "1h" }));
	// Remix fingerprints its assets so we can cache forever
	app.use(express.static("public/build", { immutable: true, maxAge: "1y" }));

Files in the base public folder should have a low max-age of 1h like elsewhere so that favicons, images, fonts, etc. can be updated as needed.

Actual Behavior

Due to this line everything in public gets the same cache headers:

remix/packages/remix-serve/index.ts

Line 10 in 57949fe

app.use(express.static("public", { immutable: true, maxAge: "1y" }));

This is fine for the built application files in public/build as they are fingerprinted but not for resources like favicon.icothat might need to change.

[mcansh]

hey @sheepsteak this was fixed in #2363 and released in v1.3.2