New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): add postcss as tailwindcss dependency (#1497) #1500
Conversation
Hi @navid-kalaei, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
are you using yarn to manage your dependencies? tailwind has postcss as a peer dependency and yarn doesn't automatically install those like npm does tailwindlabs/tailwindcss#6916 (comment) so it might be worth noting this in the example's README and on the styling guide |
yes, I use yarn. however, thinking of Remix as a standard project, I expect that to be easy to install with major package managers including yarn. |
If you're using the Tailwind CLI (which we are in this example), you don't need to install |
If you are using yarn you do because the tailwind cli improperly marks PostCSS as a peer dependency. See Logan's comment / link above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Problem
tailwind cannot run without postcss for the tailwindcss example
Error log
Success log
Related issue
#1497