fix(components): use typeof document #2025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeof window
isn't a good way to determine whether you're running on the server thanks to Deno supporting a globalwindow
. So this updates all our code/examples to usetypeof document
instead. This PR also adds a note about this in the gotchas page.I've added support for "good" in our code blocks on the website repo as well so you can now have "bad" and "good" code blocks :)