feat(remix-dev): only purge require cache if updated #2046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
changed the title
|
@warmpigman Could you please rebase your branch onto latest |
MichaelDeBoey
added
the
needs-response
@MichaelDeBoey I think I did so, could you check? |
github-actions
bot
removed
the
needs-response
MichaelDeBoey
requested changes
Jun 10, 2022
| for (let key in require.cache) { | ||
| if (key.startsWith(buildPath)) { | ||
| delete require.cache[key]; | ||
| if (require.cache[buildPath + "/assets.json"]?.exports.version !== JSON.parse(require('fs').readFileSync(BUILD_DIR + '/assets.json')).version) { |
There was a problem hiding this comment.
Could we make this an early return please?
This will create a positive condition (which has a lower cognitive load) + will make sure the code is less nested.
|
I'm excited to see this get fixed, but does this approach still work? As far as I can tell, Remix stopped creating that assets.json file as of v1.2.0. |
|
What about this approach ? |
|
Superceded by #5133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1818 Check version of assets.json, if it has changed, then purge require cache.