Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(templates/cloudflare-workers): prevent building twice with wrangler publish #2079

Merged
merged 1 commit into from Jul 12, 2022
Merged

fix(templates/cloudflare-workers): prevent building twice with wrangler publish #2079

merged 1 commit into from Jul 12, 2022

Conversation

mikeybinns
Copy link
Contributor

Closes: #2078

@chaance chaance changed the title Prevent building twice with wrangler publish fix: Prevent building twice with wrangler publish Feb 23, 2022
@jacob-ebey
Copy link
Member

Please target code changes against the dev branch.

@mikeybinns
Copy link
Contributor Author

No problem, I'll update this soon.

@mikeybinns mikeybinns changed the base branch from main to dev February 23, 2022 09:15
@MichaelDeBoey MichaelDeBoey changed the title fix: Prevent building twice with wrangler publish fix(templates/cloudflare-workers): prevent building twice with wrangler publish Jun 3, 2022
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main June 3, 2022 00:23
@MichaelDeBoey MichaelDeBoey added needs-response We need a response from the original author about this issue/PR template:cloudflare-workers labels Jun 3, 2022
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 3, 2022
Closed
@MichaelDeBoey
Copy link
Member

@ekosz Could you please resolve conflicts?

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022

⚠️ No Changeset found

Latest commit: 96e7b79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey merged commit 1f92d74 into remix-run:main Jul 12, 2022
This was referenced Jul 13, 2022
Merged
Merged
@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label Aug 8, 2022
@mikeybinns mikeybinns deleted the patch-4 branch September 22, 2022 15:32
@mcansh mcansh mentioned this pull request Jan 10, 2023
Closed
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 10, 2023
Merged
@Varedis Varedis mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed template:cloudflare-workers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent building twice with wrangler publish
3 participants
@mikeybinns @jacob-ebey @MichaelDeBoey